Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom token chars in (edge)ngram tokenizer #4384

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Support custom token chars in (edge)ngram tokenizer #4384

merged 1 commit into from
Feb 12, 2020

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Feb 11, 2020

Relates: #4341

This commit adds support for custom token characters for
edgengram and ngram tokenizers.

@russcam
Support custom token chars in (edge)ngram tokenizer
b14cfdc 
Relates: #4341

This commit adds support for custom token characters for
edgengram and ngram tokenizers.
@russcam russcam mentioned this pull request Feb 11, 2020
Closed
@russcam
Copy link
Contributor Author

russcam commented Feb 12, 2020

Failing tests are not related to this change. Merging in.

@russcam russcam merged commit 38ec44d into 7.x Feb 12, 2020
@russcam russcam deleted the feature/7x/custom-token-chars branch February 12, 2020 01:49
russcam added a commit that referenced this pull request Feb 12, 2020
@russcam
Support custom token chars in (edge)ngram tokenizer (#4384)
d0ef9fe 
Relates: #4341

This commit adds support for custom token characters for
edgengram and ngram tokenizers.

(cherry picked from commit 38ec44d)
@russcam
Copy link
Contributor Author

russcam commented Feb 12, 2020

ported to master d0ef9fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russcam @Mpdreamz